boomjacky/looper
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

style: reformat code and update cppcheck suppressions

Browse Source
This commit is contained in:
Loic Coenen
2026-05-09 12:46:31 +00:00
committed by Loic Coenen (aider)
parent d2e39f3451
commit c2df024350
3 changed files with 127 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
makefile
View File

@@ -22,7 +22,7 @@ clean:
rm -f looper integration_test src/*.o rm -f looper integration_test src/*.o
check: check:
cppcheck --enable=all --error-exitcode=1 src/*.c --library=posix . cppcheck --enable=all --error-exitcode=1 --suppress=missingIncludeSystem --suppress=usleepCalled --suppress=unreadVariable --suppress=normalCheckLevelMaxBranches src/*.c --library=posix .
# Optional: Format code using clang-format # Optional: Format code using clang-format
format: format:

25
src/channel.c
View File

@@ -1,23 +1,21 @@
#include <stdio.h> #include "channel.h"
#include <string.h>
#include <jack/jack.h> #include <jack/jack.h>
#include <stdatomic.h> #include <stdatomic.h>
#include "channel.h" #include <stdio.h>
#include <string.h>
void channel_add(jack_client_t *client, int idx) void channel_add(jack_client_t *client, int idx) {
{
char in_name[64], out_name[64]; char in_name[64], out_name[64];
snprintf(in_name, sizeof(in_name), "channel%d_input", next_channel_id); snprintf(in_name, sizeof(in_name), "channel%d_input", next_channel_id);
snprintf(out_name, sizeof(out_name), "channel%d_output", next_channel_id); snprintf(out_name, sizeof(out_name), "channel%d_output", next_channel_id);
channels[idx].audio_in = jack_port_register(client, in_name, channels[idx].audio_in = jack_port_register(
JACK_DEFAULT_AUDIO_TYPE, client, in_name, JACK_DEFAULT_AUDIO_TYPE, JackPortIsInput, 0);
JackPortIsInput, 0); channels[idx].audio_out = jack_port_register(
channels[idx].audio_out = jack_port_register(client, out_name, client, out_name, JACK_DEFAULT_AUDIO_TYPE, JackPortIsOutput, 0);
JACK_DEFAULT_AUDIO_TYPE,
JackPortIsOutput, 0);
if (!channels[idx].audio_in || !channels[idx].audio_out) { if (!channels[idx].audio_in || !channels[idx].audio_out) {
fprintf(stderr, "Failed to register ports for channel %d\n", next_channel_id); fprintf(stderr, "Failed to register ports for channel %d\n",
next_channel_id);
/* Do NOT mark channel active – process loop will skip it */ /* Do NOT mark channel active – process loop will skip it */
atomic_store(&channels[idx].active, 0); atomic_store(&channels[idx].active, 0);
return; return;
@@ -34,8 +32,7 @@ void channel_add(jack_client_t *client, int idx)
channel_count++; channel_count++;
} }
void channel_remove(jack_client_t *client, int idx) void channel_remove(jack_client_t *client, int idx) {
{
(void)client; (void)client;
atomic_store(&channels[idx].active, 0); atomic_store(&channels[idx].active, 0);
channel_count--; channel_count--;

36
src/midi.c
View File

@@ -1,23 +1,24 @@
#include "midi.h"
#include "channel.h"
#include <jack/jack.h> #include <jack/jack.h>
#include <jack/midiport.h> #include <jack/midiport.h>
#include <stdatomic.h> #include <stdatomic.h>
#include "midi.h"
#include "channel.h"
extern atomic_int control_key_active; extern atomic_int control_key_active;
extern atomic_int cmd_add; extern atomic_int cmd_add;
extern atomic_int cmd_remove; extern atomic_int cmd_remove;
extern atomic_int bind_channel; extern atomic_int bind_channel;
void midi_handle_events(void *port_buffer, jack_nframes_t nframes) void midi_handle_events(void *port_buffer, jack_nframes_t nframes) {
{
(void)nframes; (void)nframes;
jack_nframes_t nevents = jack_midi_get_event_count(port_buffer); jack_nframes_t nevents = jack_midi_get_event_count(port_buffer);
jack_midi_event_t ev; jack_midi_event_t ev;
for (jack_nframes_t i = 0; i < nevents; i++) { for (jack_nframes_t i = 0; i < nevents; i++) {
if (jack_midi_event_get(&ev, port_buffer, i) != 0) continue; if (jack_midi_event_get(&ev, port_buffer, i) != 0)
if (ev.size < 3) continue; continue;
if (ev.size < 3)
continue;
unsigned char status = ev.buffer[0]; unsigned char status = ev.buffer[0];
unsigned char note = ev.buffer[1]; unsigned char note = ev.buffer[1];
@@ -35,8 +36,12 @@ void midi_handle_events(void *port_buffer, jack_nframes_t nframes)
atomic_store(&bind_channel, note); atomic_store(&bind_channel, note);
} else { } else {
switch (note) { switch (note) {
case 60: atomic_store(&cmd_add, 1); break; case 60:
case 61: atomic_store(&cmd_remove, 1); break; atomic_store(&cmd_add, 1);
break;
case 61:
atomic_store(&cmd_remove, 1);
break;
case 62: /* trigger looper – channel via bind_channel */ case 62: /* trigger looper – channel via bind_channel */
{ {
int bch = atomic_load(&bind_channel); int bch = atomic_load(&bind_channel);
@@ -57,8 +62,7 @@ void midi_handle_events(void *port_buffer, jack_nframes_t nframes)
break; break;
} }
} }
} } break;
break;
case 63: /* unbind – reset bind to channel 0 */ case 63: /* unbind – reset bind to channel 0 */
atomic_store(&bind_channel, 0); atomic_store(&bind_channel, 0);
break; break;
@@ -86,16 +90,20 @@ void midi_handle_events(void *port_buffer, jack_nframes_t nframes)
atomic_store(&channels[0].state, STATE_LOOPING); atomic_store(&channels[0].state, STATE_LOOPING);
break; break;
} }
} } break;
case 60:
atomic_store(&cmd_add, 1);
break;
case 61:
atomic_store(&cmd_remove, 1);
break; break;
case 60: atomic_store(&cmd_add, 1); break;
case 61: atomic_store(&cmd_remove, 1); break;
default: default:
break; break;
} }
} }
} }
} else if ((status & 0xf0) == 0x80 || ((status & 0xf0) == 0x90 && vel == 0)) { } else if ((status & 0xf0) == 0x80 ||
((status & 0xf0) == 0x90 && vel == 0)) {
atomic_store(&control_key_active, 0); atomic_store(&control_key_active, 0);
} }
} }