From bb648d471b4de94a026bf55d728bb1748c5c9da0 Mon Sep 17 00:00:00 2001 From: Loic Coenen Date: Tue, 12 May 2026 19:58:20 +0000 Subject: [PATCH] fix: resolve cppcheck warnings for const pointer and static functions Co-authored-by: aider (deepseek/deepseek-reasoner) --- src/looper.c | 2 +- src/ringbuffer.c | 4 ++-- src/ringbuffer.h | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/looper.c b/src/looper.c index a817d74..edfd2b4 100644 --- a/src/looper.c +++ b/src/looper.c @@ -135,7 +135,7 @@ int process_callback(jack_nframes_t nframes, void *arg) { memory_order_acquire); if (r != NULL) { if (state == STATE_LOOPING && atomic_load(&channels[c].loop_count) > 0) { - float *outf = (float *)out; + const float *outf = (const float *)out; ring_write(r, outf, nframes); } } diff --git a/src/ringbuffer.c b/src/ringbuffer.c index 0f0682e..ea57ae6 100644 --- a/src/ringbuffer.c +++ b/src/ringbuffer.c @@ -30,7 +30,7 @@ void ring_destroy(RingBuf *r) { r->capacity = 0; } -size_t ring_readable(const RingBuf *r) { +static size_t ring_readable(const RingBuf *r) { size_t h = load_head(r); size_t t = load_tail(r); if (h >= t) @@ -39,7 +39,7 @@ size_t ring_readable(const RingBuf *r) { return r->capacity - (t - h); } -size_t ring_writeable(const RingBuf *r) { +static size_t ring_writeable(const RingBuf *r) { return r->capacity - 1 - ring_readable(r); } diff --git a/src/ringbuffer.h b/src/ringbuffer.h index 5d9fd58..b74a1f1 100644 --- a/src/ringbuffer.h +++ b/src/ringbuffer.h @@ -13,8 +13,6 @@ typedef struct { int ring_init(RingBuf *r, size_t capacity); void ring_destroy(RingBuf *r); -size_t ring_readable(const RingBuf *r); -size_t ring_writeable(const RingBuf *r); size_t ring_write(RingBuf *r, const float *data, size_t count); size_t ring_read(RingBuf *r, float *data, size_t count);