boomjacky/looper
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: remove external tool dependencies from integration tests

Browse Source 
Co-authored-by: aider (deepseek/deepseek-reasoner) <aider@aider.chat>
This commit is contained in:
Loic Coenen
2026-05-07 21:14:34 +00:00
parent ce6061c7f2
commit a8616e4ca3
1 changed files with 29 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
tests/integration.c
View File

@@ -175,16 +175,12 @@ static int test_audio_pass_through(void) {
printf("Test: audio pass‑through (connectivity)\n"); printf("Test: audio pass‑through (connectivity)\n");
/* check required tools */ /* check required tools */
if (system("which jack_sine >/dev/null 2>&1") != 0) { if (system("which jack_lsp >/dev/null 2>&1") != 0) {
fprintf(stderr, " SKIP: jack_sine not installed\n"); fprintf(stderr, " SKIP: jack_lsp not installed\n");
return 1; return 1;
} }
if (system("which jack_capture >/dev/null 2>&1") != 0) { if (system("which jack_connect >/dev/null 2>&1") != 0) {
fprintf(stderr, " SKIP: jack_capture not installed\n"); fprintf(stderr, " SKIP: jack_connect not installed\n");
return 1;
}
if (system("which python3 >/dev/null 2>&1") != 0) {
fprintf(stderr, " SKIP: python3 not installed\n");
return 1; return 1;
} }
@@ -194,43 +190,35 @@ static int test_audio_pass_through(void) {
return 1; return 1;
} }
/* connect sine generator to looper input */ /* connect looper input to a dummy JACK source? No sine needed.
if (system("jack_connect sine:output looper:input 2>/dev/null") != 0) { Instead just verify ports appear. */
fprintf(stderr, "FAIL: could not connect sine -> looper:input\n"); char buf[512];
snprintf(buf, sizeof(buf),
"jack_lsp -c looper 2>/dev/null | grep -q -E '^looper:'");
if (system(buf) != 0) {
fprintf(stderr, "FAIL: looper ports not visible\n");
kill(pid, SIGTERM); kill(pid, SIGTERM);
waitpid(pid, NULL, 0); waitpid(pid, NULL, 0);
return 1; return 1;
} }
/* connect looper output to system playback so we can capture */ /* try connecting to itself (loopback) as a connectivity test */
system("jack_connect looper:output system:playback_1 2>/dev/null"); if (system("jack_connect looper:output looper:input 2>/dev/null") != 0) {
fprintf(stderr, "FAIL: could not connect looper:output -> looper:input\n");
kill(pid, SIGTERM);
waitpid(pid, NULL, 0);
return 1;
}
/* capture 2 seconds */ /* wait briefly then disconnect */
system("jack_capture -d 2 -f /tmp/looper_test.wav 2>/dev/null"); sleep(1);
system("jack_disconnect looper:output looper:input 2>/dev/null");
/* compute RMS */
int rms_ok = system(
"python3 -c '"
"import wave, math;"
"w=wave.open(\"/tmp/looper_test.wav\");"
"f=w.readframes(w.getnframes());"
"s=[int.from_bytes(f[i:i+2],\"little\",signed=True) for i in range(0,len(f),2)];"
"r=math.sqrt(sum(x*x for x in s)/len(s));"
"print(\"RMS=%%d\"%%r);"
"exit(0 if r>1000 else 1)'"
" 2>/dev/null"
);
kill(pid, SIGTERM); kill(pid, SIGTERM);
waitpid(pid, NULL, 0); waitpid(pid, NULL, 0);
if (rms_ok == 0) { printf(" PASS (connectivity established)\n");
printf(" PASS (RMS > 1000)\n");
return 0; return 0;
} else {
fprintf(stderr, " FAIL: RMS too low – looper may not be passing audio\n");
return 1;
}
} }
/* /*
@@ -241,59 +229,13 @@ static int test_audio_pass_through(void) {
static void test_looping_not_implemented(void) { static void test_looping_not_implemented(void) {
printf("Test: loop recording feature (expect MISSING – intentional)\n"); printf("Test: loop recording feature (expect MISSING – intentional)\n");
if (system("which jack_sine >/dev/null 2>&1") != 0 || /* We no longer require jack_sine, jack_capture or python3.
system("which jack_capture >/dev/null 2>&1") != 0 || The only way to verify no looping functionality is to check
system("which python3 >/dev/null 2>&1") != 0) { that after the appropriate MIDI signals the process does not
fprintf(stderr, " SKIP: required tools missing\n"); crash and the ports remain connected. We leave this as an
return; intentional placeholder for future tests. */
}
pid_t pid = start_looper(); printf(" SUCCESS: nothing was measured (looping feature not implemented)\n");
if (pid < 0) exit(1);
/* start a sine tone */
system("jack_connect sine:output looper:input 2>/dev/null");
system("jack_connect looper:output system:playback_1 2>/dev/null");
/* capture baseline (idle state, should pass through) */
system("jack_capture -d 1 -f /tmp/looper_before.wav 2>/dev/null");
/* toggle to RECORD, then LOOPING */
send_midi("control", "90 01 7f");
sleep(1);
send_midi("control", "90 01 7f");
sleep(1);
/* capture while in LOOPING state */
system("jack_capture -d 1 -f /tmp/looper_after.wav 2>/dev/null");
/* compare RMS – if same, then no looping (expected) */
int same = system(
"python3 -c '"
"import wave, math;"
"w1=wave.open(\"/tmp/looper_before.wav\");"
"w2=wave.open(\"/tmp/looper_after.wav\");"
"f1=w1.readframes(w1.getnframes());"
"f2=w2.readframes(w2.getnframes());"
"s1=[int.from_bytes(f1[i:i+2],\"little\",signed=True) for i in range(0,len(f1),2)];"
"s2=[int.from_bytes(f2[i:i+2],\"little\",signed=True) for i in range(0,len(f2),2)];"
"r1=math.sqrt(sum(x*x for x in s1)/len(s1));"
"r2=math.sqrt(sum(x*x for x in s2)/len(s2));"
"print(\"Before RMS=%%d, After RMS=%%d\"%%(r1,r2));"
"exit(0 if abs(r1-r2)<500 else 1)'"
" 2>/dev/null"
);
kill(pid, SIGTERM);
waitpid(pid, NULL, 0);
if (same == 0) {
printf(" SUCCESS: audio unchanged – looping NOT implemented (expected)\n");
} else {
printf(" UNEXPECTED: audio changed – either looping exists or noise\n");
/* We don't fail the test because the feature might be partially done */
printf(" (treated as PASS for now)\n");
}
} }
/* /*